Skip to content

fix: account for shadowing children slot during migration #14224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2024
Merged

fix: account for shadowing children slot during migration #14224

merged 1 commit into from
Nov 8, 2024

Conversation

paoloricciuti
Copy link
Member

@paoloricciuti paoloricciuti commented Nov 8, 2024 •
edited
Loading

Closes #14171

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot
Copy link

changeset-bot bot commented Nov 8, 2024

🦋 Changeset detected

Latest commit: 725ada0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

Playground

pnpm add https://pkg.pr.new/svelte@14224

@dummdidumm dummdidumm merged commit f0c2d4c into main Nov 8, 2024
11 checks passed
@dummdidumm dummdidumm deleted the fix-shadowed-children-slot branch November 8, 2024 13:14
@github-actions github-actions bot mentioned this pull request Nov 8, 2024
Merged
@machycek machycek mentioned this pull request Nov 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dummdidumm dummdidumm dummdidumm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Children slot forwarding causes recursion svelte-5 migration

2 participants

@paoloricciuti @dummdidumm